New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make props more consistent with React Bootstrap #28

Open

jcw780 wants to merge 2 commits into gitbrent:master from jcw780:master

jcw780 commented Jun 22, 2020

This tries to make props more consistent with React Bootstrap components.

use className instead of style
pass CSSProperties for styles

[Warning not extensively tested so please test again before merging]

jcw780 and others added 2 commits

June 22, 2020 11:08


          fix: made props more inline with normal react-bootstrap

2de2cf7


          Merge pull request #1 from jcw780/properstyles

52d9dd7

fix: made props more inline with normal react-bootstrap

rubencm mentioned this pull request

Style prop value must be an object #21

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet