feat: space as pagedown in read-only #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar shift-space as pageup, as in browsers etc.
mstv
reviewed
Feb 1, 2025
| @@ -36,6 +36,7 @@ public abstract class TextEditorControlBase : UserControl | |||
| /// action. | |||
| /// </summary> | |||
| protected Dictionary<Keys, IEditAction> editactions = new Dictionary<Keys, IEditAction>(); | |||
| protected HashSet<Keys> readonlyactions = new HashSet<Keys>(); | |||
There was a problem hiding this comment.
Suggested change
| protected HashSet<Keys> readonlyactions = new HashSet<Keys>(); | |
| protected HashSet<Keys> readonlyonlyactions = new HashSet<Keys>(); |
or add a regarding xmldoc. Without a clarification here or in IsEditAction it is hard to grasp.
TIL, but this combination appears to be only common in web browsers. I'm not sure it's really applicable to the app.
I often work on laptops, and I can't say I missed the wheel... I'm used to trackpads and the gestures. |
|
I do not get the precision with the trackpad and it is function-key+PageDown. |
mstv
approved these changes
Feb 2, 2025
|
I plan to merge this in a couple of days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar shift-space as pageup, as in browsers etc.
Note: I would like to scroll to next file in diff lists with space too, but that need to be handled in the app.
Just as scroll, the app may override the input (similar for pagedown).
This after a few days using a laptop without a scrollwheel mouse. How can you work on a laptop?