Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add a note to install the webrick gem for Ruby 3.0 users #16137

Merged
merged 4 commits into from
Mar 18, 2022
Merged

fix: add a note to install the webrick gem for Ruby 3.0 users #16137

merged 4 commits into from
Mar 18, 2022

Conversation

riteshsp2000
Copy link
Contributor

Why:

Closes #14492

What's being changed:

  • add a note to install the webrick gem for Ruby 3.0 users under the "Build your site locally" procedural

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@riteshsp2000 riteshsp2000 self-assigned this Mar 8, 2022
@riteshsp2000 riteshsp2000 added the MLH fellowship This issue is reserved for the MLH Fellowship program label Mar 8, 2022
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/pages/setting-up-a-github-pages-site-with-jekyll/testing-your-github-pages-site-locally-with-jekyll.md Modified Original

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review pages Content related to GitHub Pages and removed triage Do not begin working on this issue until triaged by the team labels Mar 8, 2022
@ramyaparimi
Copy link
Contributor

@riteshsp2000
Thanks so much for opening a PR! I'll get this triaged for review ⚡

vgrl
vgrl requested changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@vgrl vgrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR, @riteshsp2000!

I've included some formatting and language changes, so let me know if anything is unclear or if you have any questions. ⚡

vgrl
vgrl approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@vgrl vgrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thanks so much for this contribution @riteshsp2000 🎉

@vgrl vgrl added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Mar 17, 2022
@vgrl vgrl enabled auto-merge March 17, 2022 23:25
@vgrl vgrl merged commit e913ff3 into github:main Mar 18, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@janbrasna janbrasna mentioned this pull request Feb 28, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgrl vgrl vgrl approved these changes

Assignees

@riteshsp2000 riteshsp2000

Labels
content This issue or pull request belongs to the Docs Content team MLH fellowship This issue is reserved for the MLH Fellowship program pages Content related to GitHub Pages ready to merge This pull request is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include step to add "webrick" gem on "Testing your GitHub Pages site locally with Jekyll" page
4 participants
@riteshsp2000 @ramyaparimi @vgrl @Shum5