Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note for webrick under "Testing your GitHub Pages site locally with Jekyll" #21557

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

dojutsu-user
Copy link
Contributor

Why:

Closes #20562

What's being changed (if available, include any code snippets, screenshots, or gifs):

  1. Add a note for the users to add webrick in their Gemfile if they are using Ruby 3.0 or later to test their GitHub pages site locally with Jekyll.
  2. Also, removed the old note which is saying the same thing but not very clearly.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link

welcome bot commented Oct 22, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
pages/setting-up-a-github-pages-site-with-jekyll/testing-your-github-pages-site-locally-with-jekyll.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@dojutsu-user dojutsu-user marked this pull request as ready for review October 22, 2022 11:00
@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review pages Content related to GitHub Pages and removed triage Do not begin working on this issue until triaged by the team labels Oct 24, 2022
@cmwilson21
Copy link
Contributor

@dojutsu-user Thanks so much for opening a PR! I'll get this triaged for review ⚡

Copy link
Contributor

@sophietheking sophietheking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dojutsu-user thank you so much for opening a PR! 💖
The change looks good to me, so I'll get this approved and merged for you. ⚡

@sophietheking sophietheking added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Oct 25, 2022
@cmwilson21 cmwilson21 enabled auto-merge October 26, 2022 13:20
@cmwilson21 cmwilson21 merged commit 661fff9 into github:main Oct 26, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@cmwilson21 cmwilson21 added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! pages Content related to GitHub Pages ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webricks currently not included by default in homebrew's ruby, leading to issues.
3 participants