Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adding-outside-collaborators-to-repositories-in-your-organizat… #30443

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

queenofcorgis
Copy link
Contributor

@queenofcorgis queenofcorgis commented Dec 8, 2023

…ion.md

Proposing this based on a community question: https://github.com/orgs/community/discussions/78092

Why: When a community member asked in the link above I expected to find this information in the docs, this change disseminates the information more widely than just a post in the community.

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Added sentence Outside collaborators cannot be added to a team, only members of an organization can be.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 8, 2023
Copy link
Contributor

github-actions bot commented Dec 8, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
organizations/managing-user-access-to-your-organizations-repositories/managing-outside-collaborators/adding-outside-collaborators-to-repositories-in-your-organization.md fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
ghae
fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@myarb myarb added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review organizations Content related to organizations and removed triage Do not begin working on this issue until triaged by the team labels Dec 8, 2023
@myarb
Copy link
Contributor

myarb commented Dec 8, 2023

👋🏼 Hello again, @queenofcorgis ! Thanks for another PR to update GitHub Docs ✨ I'll link to your other open PR, as they're related enough to review together: #30444. I've triaged it for review by someone on our team.

@queenofcorgis
Copy link
Contributor Author

Thanks @myarb for linking and thanks to you and all the docs team, big fan of your work!

@sophietheking sophietheking self-requested a review December 11, 2023 09:06
sophietheking
sophietheking previously approved these changes Dec 11, 2023
Copy link
Contributor

@sophietheking sophietheking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@queenofcorgis 👋 Thanks for opening this PR! I left a suggestion to slightly alter the wording. Please feel free to @mention me to get this merged.

…ns-repositories/managing-outside-collaborators/adding-outside-collaborators-to-repositories-in-your-organization.md

Co-authored-by: Sophie <[email protected]>
@queenofcorgis
Copy link
Contributor Author

@sophietheking love the suggestion and good to "run into" you 😃 I committed it!

@sophietheking sophietheking added this pull request to the merge queue Dec 12, 2023
Merged via the queue into github:main with commit 40b02ac Dec 12, 2023
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team organizations Content related to organizations waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants