Do not panic on metrics operations that statsd does not support #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove panics when an application uses a method like
Counter::absolute()which Statsd does not support.The panics were at least very in-your-face so users would know that something is wrong; but it's more important for this crate to serve as a drop-in replacement for other metrics exporters.
Added this warning to the docs:
metrics::Counter::absolute], [metrics::Gauge::increment], and[
metrics::Gauge::decrement] are not supported. Statsd doesn't have these concepts.Unfortunately this means that if the application is using these methods, the metrics will
silently be missing or wrong.