Skip to content

fix: notarize process #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

fix: notarize process #1940

merged 1 commit into from
Apr 4, 2025

Conversation

setchy
Copy link
Member

@setchy setchy commented Apr 3, 2025

Based on my experience releasing the latest version of Atlassify - https://github.com/setchy/atlassify/releases/tag/v1.15.0

Signed-off-by: Adam Setch <[email protected]>
@setchy setchy added this to the Release 6.3.0 milestone Apr 3, 2025
@github-actions github-actions bot added bug Something isn't working dependency Dependency updates labels Apr 3, 2025
@setchy setchy added build Build, action or package manager changes and removed bug Something isn't working dependency Dependency updates labels Apr 3, 2025
Copy link

sonarqubecloud bot commented Apr 3, 2025

@@ -99,7 +99,7 @@
"css-minimizer-webpack-plugin": "7.0.2",
"date-fns": "4.1.0",
"electron": "35.1.2",
"electron-builder": "26.0.12",
"electron-builder": "25.1.8",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it needs to be downgraded then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, yes. The newer electron-builder throws some errors I haven't had time to debug yet

@setchy setchy merged commit af40661 into main Apr 4, 2025
14 checks passed
@setchy setchy deleted the fix/notarize-process branch April 4, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build, action or package manager changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants