Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add headPipeline to MergeRequest #890

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Add headPipeline to MergeRequest #890

merged 2 commits into from
Apr 19, 2023

Conversation

vimsucks
Copy link
Contributor

jmini
jmini requested changes Mar 17, 2023
View reviewed changes
Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would do minor changes to be consistent with the rest of the code. But for me this change looks good to me.

@vimsucks @jmini
Apply suggestions from code review
e746e9a 
Co-authored-by: Jérémie Bresson <[email protected]>
@vimsucks
Copy link
Contributor Author

I would do minor changes to be consistent with the rest of the code. But for me this change looks good to me.

thanks! suggestion applied

@jmini jmini merged commit 2d2fe24 into gitlab4j:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmini jmini jmini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vimsucks @jmini