Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EventsApi.java #905

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Update EventsApi.java #905

merged 1 commit into from
Mar 16, 2023

Conversation

chenlingmin
Copy link
Contributor

change projectIdOrPath as Object type

@chenlingmin
Update EventsApi.java
c216fd6 
change projectIdOrPath as Object type
@jhult
Copy link

jhult commented Feb 13, 2023

This is consistent with how this is everywhere else (an Object is used).

The documentation also states that projectIdOrPath can be an integer/string (The ID or URL-encoded path of the project).

image

So, I think this should be merged.

@jmini
Copy link
Collaborator

jmini commented Mar 16, 2023

@jhult thanks for your review on this!

@jmini jmini merged commit b2942f3 into gitlab4j:master Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenlingmin @jhult @jmini