-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add reviewers related fields to MergeRequestEvent webhook event #916
add reviewers related fields to MergeRequestEvent webhook event #916
Conversation
Hi @jabby |
Hi @bwaldvogel |
duplicate 879 |
@mifitous Both PRs have identical file changes so the pipeline test failures cant be PR related. I'll let the maintainers decide, but it's obviously not a great practice to pollute the PR log with identical PRs just because older ones don't get maintainers' attention. |
@tabilzad : I see #879 is opened for already more than 3 month, and no maintainer even reacted. I'm fine for having it either way, but it seems we may need to envisage adding more active maintainers to this repo... |
Hi @jabby |
In my opinion the merge-request-event.json should be updated so that it has the new attribute Check "Payload example" in Merge request events |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the JSON file corresponding to this change should be updated as well.
Hi @jmini |
1fb0272
to
e4d13ac
Compare
Hi @jmini |
I have updated the example JSON one more time, because it seems that we are not supporting all the fields you added (can be done in a follow up step) |
This PR will add the missing reviewers fields to the MergeRequestEvent
List<Reviewer> reviewers
at top level ofMergeRequestEvent.java
List<Long> reviewerIds
to ObjectAttributes ofMergeRequestEvent.java
https://docs.gitlab.com/ee/user/project/integrations/webhook_events.html#merge-request-events
Fix for issue Ability to Filter Merge Request by Reviewer Id #820