Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reviewers related fields to MergeRequestEvent webhook event #916

Merged

Conversation

mifitous
Copy link
Contributor

@mifitous mifitous commented Feb 16, 2023

This PR will add the missing reviewers fields to the MergeRequestEvent

@mifitous
Copy link
Contributor Author

Hi @jabby
Can you please review and trigger checks?
Merci beaucoup

@mifitous
Copy link
Contributor Author

@gmessner @tubbynl @krische @PhilippeVienne @lamdav
Hello dear gentlemen

Can someone of you please review it? It is blocking us from delivering another fix in a Jenkins plug-in

Sincerely,
@mifitous

@mifitous
Copy link
Contributor Author

Hi @bwaldvogel
Maybe you can review it please?

@tabilzad
Copy link

duplicate 879

@mifitous
Copy link
Contributor Author

duplicate 879

Hi @tabilzad
This one has passed all tests on my machine, so wondering if we can close #879 and ack this one please?

@tabilzad
Copy link

tabilzad commented Feb 20, 2023

@mifitous Both PRs have identical file changes so the pipeline test failures cant be PR related. I'll let the maintainers decide, but it's obviously not a great practice to pollute the PR log with identical PRs just because older ones don't get maintainers' attention.

@mifitous
Copy link
Contributor Author

@mifitous Both PRs have identical file changes so the pipeline test failures cant be PR related. I'll let the maintainers decide, but it's obviously not a great practice to pollute the PR log with identical PRs just because older ones don't get maintainers' attention.

@tabilzad : I see #879 is opened for already more than 3 month, and no maintainer even reacted. I'm fine for having it either way, but it seems we may need to envisage adding more active maintainers to this repo...

@mifitous
Copy link
Contributor Author

mifitous commented Mar 8, 2023

Hi @jabby
Can you please review and trigger checks?
Merci beaucoup

@jmini
Copy link
Collaborator

jmini commented Mar 14, 2023

In my opinion the merge-request-event.json should be updated so that it has the new attribute reviewers.

Check "Payload example" in Merge request events

Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the JSON file corresponding to this change should be updated as well.

@mifitous
Copy link
Contributor Author

Hi @jmini
Will have a look, Thank you

@mifitous mifitous force-pushed the add-missing-reviewers-to-MergeRequestEvent branch from 1fb0272 to e4d13ac Compare March 21, 2023 12:18
@mifitous
Copy link
Contributor Author

mifitous commented Apr 2, 2023

I think the JSON file corresponding to this change should be updated as well.

Hi @jmini
updated

@jmini
Copy link
Collaborator

jmini commented Apr 4, 2023

I have updated the example JSON one more time, because it seems that we are not supporting all the fields you added (can be done in a follow up step)

@mifitous
Copy link
Contributor Author

mifitous commented Apr 8, 2023

Hi @jabby / @gmessner
Can you please trigger a new release to get this PR delivered? #945

@mifitous mifitous restored the add-missing-reviewers-to-MergeRequestEvent branch April 17, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants