Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace GIT_SSH with GIT_SSH_COMMAND for SSH key management. #256

Merged
merged 1 commit into from
Apr 8, 2015
Merged

Replace GIT_SSH with GIT_SSH_COMMAND for SSH key management. #256

merged 1 commit into from
Apr 8, 2015

Conversation

teeberg
Copy link
Contributor

@teeberg teeberg commented Feb 9, 2015

Also move untestable documentation out of test.

Related: #234, #242

@teeberg
Replace GIT_SSH with GIT_SSH_COMMAND for SSH key management.
158bc98 
Also move untestable documentation out of test.

Related: #234, #242
@teeberg
Copy link
Contributor Author

teeberg commented Feb 9, 2015

I actually think it's a really cool idea to test the documentation like this, but if you have to say that we don't actually make the call because the test setup won't allow us to, I'd rather remove it from the test... :-)

@Byron
Copy link
Member

Byron commented Feb 10, 2015

Thank you ! I wouldn't mind putting in the example in clear-text in this case.
However, as GitPython aims to support multiple different versions of the git commandline program, it would be great to keep both versions, stating which git --version you require to make use of either one.
Do you think you can make this change for me so I can make the merge ?
Thanks in advance

@Byron Byron added this to the v0.3.7 - Fixes milestone Feb 10, 2015
@Byron
Copy link
Member

Byron commented Apr 7, 2015

I'd like to make a new release this week, and would be glad if I could merge this PR. Can you have a look at my previous request ? It shouldn't take long. If you have no time for this just let me know and I will do it for you.
Thanks

@Byron Byron merged commit 158bc98 into gitpython-developers:master Apr 8, 2015
Byron added a commit that referenced this pull request Apr 8, 2015
@Byron
docs(tutorial): add pre-v2.3 GIT_SSH example
6cc1e7e 
It goes along with the new one advertising the GIT_SSH_COMMAND
environment variable.

Related to #256
Byron added a commit that referenced this pull request Apr 8, 2015
@Byron
docs(tutorial): fix GIT_SSH examples
545ac25 
They didn't show up as code-block

Related to #256
@Byron
Copy link
Member

Byron commented Apr 8, 2015

You can watch the development stream on youtube.

@teeberg
Copy link
Contributor Author

teeberg commented Apr 8, 2015

Thanks for taking over. :-) I was willing to do it, but I'm indeed rather busy and it probably takes you way less time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
v0.3.7 - Fixes
Development

Successfully merging this pull request may close these issues.
2 participants
@teeberg @Byron