Produce valid syntax for function type params #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #76, originally raised by @esaulpaugh.
This PR ensures the resulting Solidity output for function type parameters will always be valid.
In cases where the
internalType
field is provided, this change uses that field directly for best results. Since that field is not part of the ABI JSON spec, then in cases where it's not provided, this PR falls back to behavior of specifying the minimally-validfunction() external
type alongside a warning.Example missing `internalType` fallback output