Enable attribute update on resource-type API. #1062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedro-martins
force-pushed
the
upstream/feature/enable-attribute-update-on-resource-type-api
branch
3 times, most recently
from
ad64f96 to
25e6ac6
Compare
jd
requested changes
Dec 28, 2020
gnocchi/rest/api.py
Outdated
|
|
||
| return update_attrs | ||
| except Exception: | ||
| abort(400, "Unable to update attributes [%s]." % update_attrs) |
There was a problem hiding this comment.
That does not look like a 400: if it's a 400 you must be able to explain what's wrong to the client.
If you're unable to execute the request it's more likely a 500 and a bug in the code itself.
I'd rather not try/except anything here.
pedro-martins
force-pushed
the
upstream/feature/enable-attribute-update-on-resource-type-api
branch
from
25e6ac6 to
1982d8b
Compare
jd
reviewed
Dec 28, 2020
pedro-martins
force-pushed
the
upstream/feature/enable-attribute-update-on-resource-type-api
branch
3 times, most recently
from
4c0eb1b to
febac0a
Compare
Currently, the resource-type API, not allow operators to update resource type's attributes, the API only allows Add and Delete. So, if an operator desires to change a required resource type's attribute to optional and vice-versa, he/she will need to do it manually in the database or deleting and creating the attribute again, but it will result in the attribute's history lose. Therefore, to help operators in that situation, I propose to enhance the Resource-type API to allow updates while adding a new attribute. If the new attribute already exists and is different from the old, it will be updated; otherwise, nothing will happen and we will return the resource type's attribute list as the old behavior. The first version of this implementation will not allow updating the resource type's attribute's type.
pedro-martins
force-pushed
the
upstream/feature/enable-attribute-update-on-resource-type-api
branch
from
febac0a to
13f6eb9
Compare
mrunge
reviewed
Feb 17, 2021
jd
approved these changes
Feb 17, 2021
…n-resource-type-api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the resource-type API, not allow operators to update
resource type's attributes, the API only allows Add and Delete.
So, if an operator desires to change a required resource type's
attribute to optional and vice-versa, he/she will need to do it
manually in the database or deleting and creating the attribute
again, but it will result in the attribute's history lose.
Therefore, to help operators in that situation, I propose to
enhance the Resource-type API to allow updates while adding a
new attribute. If the new attribute already exists and is
different from the old, it will be updated; otherwise, nothing
will happen and we will return the resource type's attribute
list as the old behavior.
The first version of this implementation will not allow updating
the resource type's attribute's type.