Fix yaml deprecation warning #1099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd
approved these changes
Dec 11, 2020
jd
requested changes
Dec 11, 2020
gnocchi/gendoc.py
Outdated
| @@ -194,7 +194,7 @@ def setup(app): | |||
|
|
|||
| # TODO(jd) Do not hardcode doc/source | |||
| with open("doc/source/rest.yaml") as f: | |||
| scenarios = ScenarioList(yaml.load(f)) | |||
| scenarios = ScenarioList(yaml.load(f), Loader=yaml.FullLoader) | |||
There was a problem hiding this comment.
embarrassing. Yes, of course!
YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
jd
approved these changes
Dec 11, 2020
|
Thank you for looking at this Julien! |
|
#1097 also contains a commit to pin chardet<4, which seems to be necessary here as well? Let's see if the other patch passes. |
|
It seems pinning chardet is necessary here for the time being. @jd may I ask for a review again? |
|
@Mergifyio refresh |
|
Command
|
|
Thank you. |
|
@Mergifyio backport-to-4.3 |
|
Command
|
|
@Mergifyio backport stable/4.3 |
|
Command
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated,
as the default Loader is unsafe. Please read https://msg.pyyaml.org/load
for full details.