Skip to content

Dismiss reviews after pushing a new commit #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Conversation

mrunge
Copy link
Contributor

@mrunge mrunge commented Jan 20, 2021

to prevent accidental merges of non-reviewed
changes.

Related: Mergifyio/mergify#1860

to prevent accidental merges of non-reviewed
changes.

Related: Mergifyio/mergify#1860
.mergify.yml Outdated
Comment on lines 26 to 27
contitions:
- .*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
contitions:
- .*
conditions: []

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will do that

@mrunge
Copy link
Contributor Author

mrunge commented Jan 20, 2021

Shouldn't the update also dismiss the change request?

@jd
Copy link
Member

jd commented Jan 20, 2021

It will, once this is merged.

@jd jd merged commit 2865e65 into gnocchixyz:master Jan 20, 2021
@mrunge
Copy link
Contributor Author

mrunge commented Jan 20, 2021

Okay, thank you Julien!

@mrunge mrunge deleted the mergify branch January 20, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants