Skip to content

ci: dont run actions on push and dont hardcode default branch #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2021

Conversation

tobias-urdin
Copy link
Contributor

@tobias-urdin tobias-urdin commented Jul 7, 2021

Only run the actions on PR and not
on push because that runs the actions
when a PR is merged.

Dont hardcode the default branch to master
since it actions will use the same ref/commit
that it's going to test when loading workflows.

Removing the default branch makes it easier to
just backport later.

@tobias-urdin tobias-urdin changed the title ci: dont run actions on push ci: dont run actions on push and dont hardcode default branch Jul 7, 2021
@tobias-urdin
Copy link
Contributor Author

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2021

Command rebase: failure

Pull request can't be updated with latest base branch changes
GitHub App like Mergify are not allowed to rebase pull request where .github/workflows is changed.
This pull request must be rebased manually.
err-code: 5D7B4

Only run the actions on PR and not
on push because that runs the actions
when a PR is merged.
Don't hardcode the master branch since it will
checkout workflows on the same ref/commit we
dont need to set it here.

This makes it easier to backport since we don't
have to replace any branches.
@tobias-urdin tobias-urdin merged commit 02fdd7f into gnocchixyz:master Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants