dynamic aggregates - metric not found #1202
Conversation
|
@javacruft Please add a release note to the change. To give a little bit of context on this change, the legacy API always returned 404 when doing aggregation and thus the Aodh alarm code simple allows that as in [1] introduced in [2]. The problem is that in the new dynamic aggregates API the change [3] introduced an error 400 for the MetricNotFound exception when not grouping and ignored missing metrics for grouped queries, this 400 error can be confused with a faulty formatted aggregation query and breaks the Aodh alarm code and thus the logic introduced in [2]. This was observed when moving Aodh to the new dynamic aggregates API as in done in [4]. We can introduce this behavior change to properly be a 404 HTTP response when the metric is not found in master but not backport to stable/4.4 - either way it was a while since we had a new release so hopefully we could release a 4.5 in a short while. I would like to know the status of RDO and Ubuntu packaging though and see if we could EOL stable/4.3 release since there is no testing for that release anymore, we only keep 4.4 and master alive right now. [1] https://opendev.org/openstack/aodh/src/branch/master/aodh/api/controllers/v2/alarm_rules/gnocchi.py#L217 |
|
Maybe @jd wants to comment on this behavior change. |
|
This implements the correct behavior imho, but maybe I am missing something? Apparently, the latest build for RDO is gnocchi-4.3.6-1.el8 |
Return a 404 (metric not found) rather than 400 (bad request) when metrics associated with a dynamic aggregate are not found.
javacruft
force-pushed
the
aggregates-metricnotfound
branch
from
434d78c to
a0a9c2c
Compare
Done |
Return a 404 (metric not found) rather than 400 (bad request) when
metrics associated with a dynamic aggregate are not found.