Fix issue with None value attributes #1287
Conversation
rafaelweingartner
force-pushed
the
fix_gnocchi_issue_with_python3
branch
2 times, most recently
from
39baffb to
baea0a1
Compare
|
@tobias-urdin this is also an important one. However, its tests will only pass after the following patches have been merged: |
|
Could this be reproduced with a test? I'm trying to understand what the change will do to the grouped data, will there be entries with an empty string? Should those be filtered out instead? |
|
The code is not designed in a way that enables us to easily do a unit testing. Let me think about what we can do here. |
|
@Mergifyio rebase |
|
To get the future behavior now, you can configure Or you can create a dedicated github account for squash and rebase operations, and use it in different |
✅ Branch has been successfully rebased |
chungg
force-pushed
the
fix_gnocchi_issue_with_python3
branch
from
baea0a1 to
97f04f8
Compare
Version 2 of SQL Alchemy has been released, and it brings considerable changes to it [1]. The one that is affecting us right away is the philosophy of always using a transaction. That means, for every connection open with the database (DB), there is automatically a transaction opened. This, in turn, breaks the current code structure that we have, where we try to open a transaction every time we get a connection to write or read in the DB. The break happens because the code is trying to open a transaction inside an already existing one (the transaction opened by SQL Alchemy itself). This whole situation only happens with SQL Alchemy >=2. Therefore, for now, the solution is to pin down its (SQL Alchemy) version until we have a final solution, which is going to have a considerable impact in the transaction management that we currently have. [1] https://pypi.org/project/SQLAlchemy/2.0.0/
With Python 3, the ``sort`` function is not handling `None` values. Therefore, when we handle resources with values as ``None`` an exception happens. This patch fixes such situations.
rafaelweingartner
force-pushed
the
fix_gnocchi_issue_with_python3
branch
from
a7cc83a to
d2fa86f
Compare
|
@tobias-urdin I added the unit tests for this one, as you suggested. |
|
Thanks @rafaelweingartner – let me know if you have anything else you want in master I will cut a 4.5 release sometime this week. |
With respect of Gnocchi server, I think everything is fine. Only the Gnocchi client where I Think there is that adjust in the handling of exceptions that we should discuss a little bit more, and maybe generate a new version of the client as well. |
With Python 3, the
sortfunction is not handlingNonevalues. Therefore, when we handle resources with values asNonean exception happens. This patch fixes such situations.