-
Notifications
You must be signed in to change notification settings - Fork 84
Update tests error messages to be compatible with voluptuous 0.14.0 #1362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tobias-urdin
merged 1 commit into
gnocchixyz:master
from
pedro-martins:fix-messages-validation-in-tests-due-voluptuous-update-0-14-0
Dec 3, 2023
Merged
Update tests error messages to be compatible with voluptuous 0.14.0 #1362
tobias-urdin
merged 1 commit into
gnocchixyz:master
from
pedro-martins:fix-messages-validation-in-tests-due-voluptuous-update-0-14-0
Dec 3, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit alecthomas/voluptuous@41bc53d which was introduced in version 0.14.0 of voluptuous library, improves the error messages for invalid keys. To make Gnocchi tests compatible with this new version, we need to update some error messages validation to use the newest error messages from voluptuous parser.
rafaelweingartner
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Pedro!
Guys, we need to merge this one, to fix the CI for the other patches. |
@Mergifyio backport stable/4.6 |
✅ Backports have been created
|
@Mergifyio backport stable/4.5 |
✅ Backports have been created
|
@Mergifyio backport stable/4.4 |
✅ Backports have been created
|
This was referenced Dec 3, 2023
tobias-urdin
added a commit
that referenced
this pull request
Dec 6, 2023
Update tests error messages to be compatible with voluptuous 0.14.0 (backport #1362)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit alecthomas/voluptuous@41bc53d, which was introduced in version 0.14.0 of voluptuous library, improves the error messages for invalid keys.
To make Gnocchi tests compatible with this new version, we need to update some error messages validation to use the newest error messages from voluptuous parser.