Skip to content

Update tests error messages to be compatible with voluptuous 0.14.0 #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pedro-martins
Copy link
Contributor

The commit alecthomas/voluptuous@41bc53d, which was introduced in version 0.14.0 of voluptuous library, improves the error messages for invalid keys.

To make Gnocchi tests compatible with this new version, we need to update some error messages validation to use the newest error messages from voluptuous parser.

The commit

alecthomas/voluptuous@41bc53d

which was introduced in version 0.14.0 of voluptuous library,
improves the error messages for invalid keys. To make Gnocchi
tests compatible with this new version, we need to update some
error messages validation to use the newest error messages from
voluptuous parser.
Copy link
Contributor

@rafaelweingartner rafaelweingartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pedro!

@rafaelweingartner
Copy link
Contributor

Guys, we need to merge this one, to fix the CI for the other patches.

@tobias-urdin tobias-urdin merged commit e0eaa78 into gnocchixyz:master Dec 3, 2023
@tobias-urdin
Copy link
Contributor

@Mergifyio backport stable/4.6

Copy link
Contributor

mergify bot commented Dec 3, 2023

backport stable/4.6

✅ Backports have been created

@tobias-urdin
Copy link
Contributor

@Mergifyio backport stable/4.5

Copy link
Contributor

mergify bot commented Dec 3, 2023

backport stable/4.5

✅ Backports have been created

@tobias-urdin
Copy link
Contributor

@Mergifyio backport stable/4.4

Copy link
Contributor

mergify bot commented Dec 3, 2023

backport stable/4.4

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants