redis: Fix types of some options #1372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The socket_keepalive option in RedisClient is not an integer but a boolean. Also the healthcheck_interval option can accept not only integers but also float values. This fixes the types to parse these options accordingly. Note this change still keeps support for socket_keepalive=1 or socket_keepalive=0 , but would remove support for the other integer values such as 2 or -1.
kajinamit
force-pushed
the
redis-opt-type-fix
branch
from
f66dab0 to
2b4f38b
Compare
| ]) | ||
|
|
||
| #: Client arguments that are expected to be float convertible. | ||
| CLIENT_FLOAT_ARGS = frozenset([ | ||
| 'socket_timeout', | ||
| 'health_check_interval', |
There was a problem hiding this comment.
Is this change intended?
There was a problem hiding this comment.
Yes. I think it is explained in the PR comment as well as the commit message ?
There was a problem hiding this comment.
I see. I missed the second sentence 😑. Sorry for that.
rafaelweingartner
approved these changes
Feb 28, 2024
tobias-urdin
approved these changes
Feb 29, 2024
|
@Mergifyio backport stable/4.6 |
✅ Backports have been created
|
tobias-urdin
added a commit
that referenced
this pull request
Aug 20, 2024
redis: Fix types of some options (backport #1372)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The socket_keepalive option in RedisClient is not an integer but a boolean. Also the healthcheck_interval option can accept not only integers but also float values. This fixes the types to parse these options accordingly.
Note this change still keeps support for socket_keepalive=1 or socket_keepalive=0 , but would remove support for the other integer values such as 2 or -1.