v38 migration used an outdated version of RepoUnit model #2602
+32
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Schneiderbauer <[email protected]>
Signed-off-by: David Schneiderbauer <[email protected]>
Signed-off-by: David Schneiderbauer <[email protected]>
|
LGTM |
sapk
approved these changes
Sep 25, 2017
|
Not blocking but shouldn't it be also a custom type V38RepoUnit ? It would limit in futur mistake like that ? |
tboerger
added
the
lgtm/need 1
lafriks
requested changes
Sep 25, 2017
models/migrations/v16.go
Outdated
| // RepoUnit describes all units of a repository | ||
| type RepoUnit struct { | ||
| // V16RepoUnit describes all units of a repository | ||
| type V16RepoUnit struct { |
There was a problem hiding this comment.
Better is to move type inside migration function so that you don't need to rename it and don't need table name function
models/migrations/v38.go
Outdated
| "github.com/go-xorm/xorm" | ||
| ) | ||
|
|
||
| // RepoUnit describes all units of a repository | ||
| type RepoUnit struct { |
There was a problem hiding this comment.
Same as above, move it inside migration function
|
Or like https://github.com/go-gitea/gitea/blob/master/models/migrations/v40.go defining the struct inside the func. |
|
@lafriks suggesting the same. |
Signed-off-by: David Schneiderbauer <[email protected]>
lafriks
approved these changes
Sep 25, 2017
|
LGTM |
tboerger
added
lgtm/done
daviian
added a commit
to daviian/gitea
that referenced
this pull request
Sep 25, 2017
* change repoUnit model in migration * fix v16 migration repo_unit table * fix lint error * move type definition inside function Signed-off-by: David Schneiderbauer <[email protected]>
daviian
added a commit
to daviian/gitea
that referenced
this pull request
Sep 28, 2017
* change repoUnit model in migration * fix v16 migration repo_unit table * fix lint error * move type definition inside function Signed-off-by: David Schneiderbauer <[email protected]>
lunny
pushed a commit
that referenced
this pull request
Oct 8, 2017
* v38 migration used an outdated version of RepoUnit model (#2602) * change repoUnit model in migration * fix v16 migration repo_unit table * fix lint error * move type definition inside function Signed-off-by: David Schneiderbauer <[email protected]> * fix lint error Signed-off-by: David Schneiderbauer <[email protected]> * Fix time tracking migration * Refactor code * Fix migration from Gogs * v38 migration used an outdated version of RepoUnit model (#2602) * change repoUnit model in migration * fix v16 migration repo_unit table * fix lint error * move type definition inside function Signed-off-by: David Schneiderbauer <[email protected]> * fix lint error Signed-off-by: David Schneiderbauer <[email protected]> * Fix time tracking migration * Refactor code * Fix migration from Gogs * add error check Signed-off-by: David Schneiderbauer <[email protected]> * Additiomal fixes for migrations * Fix timetracking migration * Add back nil check
daviian
added a commit
to daviian/gitea
that referenced
this pull request
Oct 9, 2017
* v38 migration used an outdated version of RepoUnit model (go-gitea#2602) * change repoUnit model in migration * fix v16 migration repo_unit table * fix lint error * move type definition inside function * Fix migration from Gogs * Refactor code * add error check * Additiomal fixes for migrations * Add back nil check
lafriks
pushed a commit
that referenced
this pull request
Oct 9, 2017
* Rewrite migrations to not depend on future code changes (#2604) * v38 migration used an outdated version of RepoUnit model (#2602) * change repoUnit model in migration * fix v16 migration repo_unit table * fix lint error * move type definition inside function * Fix migration from Gogs * Refactor code * add error check * Additiomal fixes for migrations * Add back nil check * replace deprecated .Id with .ID Signed-off-by: David Schneiderbauer <[email protected]> * change string map to interface map Signed-off-by: David Schneiderbauer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v38 migration used an old version of RepoUnit.
Changed to current RepoUnit model