Refactor Branch struct in package modules/git #33980
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
github-actions
bot
added
modifies/api
lunny
changed the title
pull-request-size
bot
added
size/L
lunny
commented
Mar 23, 2025
| @@ -169,13 +169,6 @@ func ToAPIPullRequest(ctx context.Context, pr *issues_model.PullRequest, doer *u | |||
| } | |||
|
|
|||
| if pr.Flow == issues_model.PullRequestFlowAGit { | |||
| gitRepo, err := gitrepo.OpenRepository(ctx, pr.BaseRepo) | |||
There was a problem hiding this comment.
Line 146 has created gitRepo.
lunny
force-pushed
the
lunny/remove_unnecessary_repo_branch
branch
from
d537b13 to
c46d935
Compare
yp05327
reviewed
Mar 25, 2025
| @@ -68,34 +56,11 @@ func GetDefaultBranch(ctx context.Context, repoPath string) (string, error) { | |||
| } | |||
|
|
|||
| // GetBranch returns a branch by it's name | |||
| func (repo *Repository) GetBranch(branch string) (*Branch, error) { | |||
| func (repo *Repository) GetBranch(branch string) (string, error) { | |||
There was a problem hiding this comment.
This function can be replaced by repo.IsBranchExist, so this function can be removed?
yp05327
reviewed
Mar 25, 2025
| // GetHEADBranch returns corresponding branch of HEAD. | ||
| func (repo *Repository) GetHEADBranch() (*Branch, error) { | ||
| func (repo *Repository) GetHEADBranch() (string, error) { |
There was a problem hiding this comment.
GetHEADBranchName maybe better, as this can be easily considered that the return is a string.
yp05327
reviewed
Mar 25, 2025
| @@ -28,8 +28,8 @@ import ( | |||
| // Optional - Merger | |||
| func ToAPIPullRequest(ctx context.Context, pr *issues_model.PullRequest, doer *user_model.User) *api.PullRequest { | |||
| var ( | |||
| baseBranch *git.Branch | |||
| headBranch *git.Branch | |||
| baseBranch string | |||
There was a problem hiding this comment.
baseBranchName & headBranchName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Branchstruct inmodules/gitpackage is unnecessary. We can just use astringto represent a branch