Update to support golangci-lint v2 #366
Merged
+89
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pohly
reviewed
Apr 7, 2025
| @@ -41,17 +41,17 @@ type stdoutlogger struct { | |||
| } | |||
|
|
|||
| func (l stdoutlogger) WithName(name string) logr.LogSink { | |||
| l.Formatter.AddName(name) | |||
| l.AddName(name) | |||
There was a problem hiding this comment.
Is this something that we might want to enable as hint in Kubernetes? Or is it too subjective?
There was a problem hiding this comment.
It's CORRECT but not obviously BETTER, IMO. I decided not to fight it here.
| @@ -32,42 +32,42 @@ import ( | |||
| // | |||
|
|
|||
| func BenchmarkSlogSinkLogInfoOneArg(b *testing.B) { | |||
| var log logr.Logger = logr.FromSlogHandler(logr.ToSlogHandler(logr.Discard())) | |||
| var log logr.Logger = logr.FromSlogHandler(logr.ToSlogHandler(logr.Discard())) //nolint:staticcheck | |||
There was a problem hiding this comment.
Any reason to keep the var log logr.Logger = instead of replacing with log :=?
I don't remember why I wrote it like this other than more clearly showing the type.
There was a problem hiding this comment.
I like the clarity in the benchmark.
There was a problem hiding this comment.
Probably that was why I did it - if only I remembered... 😅
pohly
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.