Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement adapter Name and add Name constant #53

Merged
merged 7 commits into from
Nov 6, 2023

Conversation

lafriks
Copy link
Contributor

@lafriks lafriks commented Oct 16, 2023

Closes #55, closes #58 and closes #60

@lafriks lafriks added the enhancement New feature or request label Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (944bbb1) 100.00% compared to head (8356432) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #53   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          155       157    +2     
=========================================
+ Hits           155       157    +2     
Files Coverage Δ
mysql.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fs02
Copy link
Member

Fs02 commented Oct 28, 2023

hello, can you fix the status check?
100% code coverage is a rule here, please understand it 🙏

@lafriks
Copy link
Contributor Author

lafriks commented Nov 5, 2023

Status check fixed

Copy link
Member

@Fs02 Fs02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

}
}

var dbOpen = db.Open
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely one way to do it 👍

@Fs02 Fs02 merged commit 21b9310 into go-rel:main Nov 6, 2023
@lafriks lafriks deleted the feat/adapter_dbtype branch November 6, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants