-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
sources/ldap: align group membership mapping with memberUid by using 'uid' #14162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Replaced LDAP_UNIQUENESS with 'uid' as membership_mapping_attribute in authentik/sources/ldap/sync/membership.py to ensure correct resolution of group memberships when syncing from LDAP directories using memberUid (e.g., OpenLDAP). This change improves compatibility and removes the need for schema workarounds. Signed-off-by: william-code87 <[email protected]>
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14162 +/- ##
==========================================
- Coverage 92.74% 86.30% -6.45%
==========================================
Files 799 809 +10
Lines 41232 41543 +311
==========================================
- Hits 38241 35853 -2388
- Misses 2991 5690 +2699
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…from DN Signed-off-by: william-code87 <[email protected]>
…gnment Signed-off-by: william-code87 <[email protected]>
…c logic Signed-off-by: william-code87 <[email protected]>
why is |
I believe the unrelated code changes were caused by running |
Hi maintainers, 👋 I've updated the LDAP group membership sync logic to correctly handle Requesting approval to continue with full CI test runs. Thank you for your time and feedback! |
…nt() Signed-off-by: william-code87 <[email protected]>
Hi, sorry for the earlier issue — I realized I missed updating one line in |
Details
Replaced
LDAP_UNIQUENESS
with'uid'
asmembership_mapping_attribute
inauthentik/sources/ldap/sync/membership.py
to ensure correct resolution of group memberships when syncing from LDAP directories usingmemberUid
(e.g., OpenLDAP).🔍 Rationale
memberUid
in Group objects typically refers touid
in User objects.cn
orentryUUID
, which causes group membership resolution to fail.'uid'
, this PR ensures proper synchronization of group memberships without requiring schema modifications or workarounds.✅ Impact
Closes #13206
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make website
)