Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]Add release.yml to automate release notes #16819

Merged

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented May 7, 2022

Use github autogeneration release notes and add action to check if the PR has labels

Complete and more readable relase notes
https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes
Signed-off-by: OrlinVasilev [email protected]

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Use github autogeneration release notes and add action to check if the PR has labels

Complete and more readable relase notes
https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes
Signed-off-by: OrlinVasilev <[email protected]>
@YangJiao0817 YangJiao0817 added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label May 7, 2022
@YangJiao0817 YangJiao0817 self-assigned this May 7, 2022
@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #16819 (55f7645) into release-2.5.0 (55f7645) will not change coverage.
The diff coverage is n/a.

❗ Current head 55f7645 differs from pull request most recent head f68ee7f. Consider uploading reports for the commit f68ee7f to get more accurate results

Impacted file tree graph

@@              Coverage Diff               @@
##           release-2.5.0   #16819   +/-   ##
==============================================
  Coverage          67.42%   67.42%           
==============================================
  Files                949      949           
  Lines              78861    78861           
  Branches            2331     2331           
==============================================
  Hits               53173    53173           
  Misses             22129    22129           
  Partials            3559     3559           
Flag Coverage Δ
unittests 67.42% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@OrlinVasilev OrlinVasilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OrlinVasilev
Copy link
Member

@YangJiao0817 For my information :) why we are cherry picking this into 2.5 branch

@YangJiao0817
Copy link
Member Author

@OrlinVasilev Because we will use this in release-2.5.1 to generate release notes.

@YangJiao0817 YangJiao0817 merged commit 4d80d7d into goharbor:release-2.5.0 May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/enhancement Label to mark PR to be added under release notes as enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants