Skip to content

Enable MAX_JOB_DURATION_SECONDS in the jobservice container #21232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

stonezdj
Copy link
Contributor

enable job service to set MAX_JOB_DURATION_SECONDS in the jobservice container to customize max job duration
fork gocraft/work to goharbor/work

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner November 22, 2024 06:20
@stonezdj stonezdj added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label Nov 22, 2024
  enable job service to set MAX_JOB_DURATION_SECONDS in the jobservice container to customize max job duration
  fork gocraft/work to goharbor/work

Signed-off-by: stonezdj <[email protected]>
@stonezdj stonezdj force-pushed the 24nov21_set_job_expire_env branch from a01a01e to 4faffd4 Compare November 22, 2024 06:21
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.28%. Comparing base (c8c11b4) to head (4faffd4).
Report is 333 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21232      +/-   ##
==========================================
+ Coverage   45.36%   46.28%   +0.91%     
==========================================
  Files         244      247       +3     
  Lines       13333    13863     +530     
  Branches     2719     2867     +148     
==========================================
+ Hits         6049     6416     +367     
- Misses       6983     7111     +128     
- Partials      301      336      +35     
Flag Coverage Δ
unittests 46.28% <ø> (+0.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 969384c into goharbor:main Nov 22, 2024
13 checks passed
ianseyer pushed a commit to ianseyer/harbor that referenced this pull request Feb 3, 2025
…#21232)

enable job service to set MAX_JOB_DURATION_SECONDS in the jobservice container to customize max job duration
  fork gocraft/work to goharbor/work

Signed-off-by: stonezdj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/test-case release-note/enhancement Label to mark PR to be added under release notes as enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants