Skip to content

feat: implement the CNAI model processor #21663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

feat: implement the CNAI model processor #21663

merged 1 commit into from
Mar 13, 2025

Conversation

chlins
Copy link
Member

@chlins chlins commented Feb 24, 2025

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #21229

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@chlins chlins added release-note/new-feature New Harbor Feature target/2.13.0 issues that are targeting v2.13.0 labels Feb 24, 2025
@chlins chlins requested a review from a team as a code owner February 24, 2025 07:08
@codecov Codecov
Copy link

codecov bot commented Feb 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.28%. Comparing base (c8c11b4) to head (72266ed).
Report is 405 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21663      +/-   ##
==========================================
+ Coverage   45.36%   46.28%   +0.91%     
==========================================
  Files         244      250       +6     
  Lines       13333    14133     +800     
  Branches     2719     2908     +189     
==========================================
+ Hits         6049     6541     +492     
- Misses       6983     7246     +263     
- Partials      301      346      +45
Flag Coverage Δ
unittests 46.28% <ø> (+0.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 494 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chlins chlins mentioned this pull request Feb 24, 2025
Open
Vad1mo
Vad1mo previously requested changes Feb 25, 2025
View reviewed changes
@chlins chlins force-pushed the feat/model-spec branch from 162737a to cc67517 Compare March 5, 2025 07:38
wy65701436
wy65701436 approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins changed the title feat: implement the AI model processor feat: implement the CNAI model processor Mar 7, 2025
@chlins chlins force-pushed the feat/model-spec branch 6 times, most recently from 7238745 to 96f6e39 Compare March 11, 2025 10:09
@chlins chlins enabled auto-merge (squash) March 12, 2025 07:27
@chlins chlins merged commit d9e71f9 into goharbor:main Mar 13, 2025
12 checks passed
Liam-Zhao added a commit to Liam-Zhao/harbor that referenced this pull request Mar 19, 2025
@Liam-Zhao
parent fef9524
874cc72 
author zhaoxinxin <[email protected]> 1741079005 +0800
committer zhaoxinxin <[email protected]> 1742381063 +0800
gpgsig -----BEGIN PGP SIGNATURE-----

 iQGzBAABCAAdFiEEjX7vigeNSJLimSPEHOcWYk0ZMdEFAmfaoAcACgkQHOcWYk0Z
 MdGa2QwArxb9MxLqdHXmb0tN18grIa6hbsKhTJ733mcUX/buOQAVa5Y4YBOoazk5
 xSGJKrnA4OLkWJq6zcMezMnzQ40eGW8cxxnCALYUqsZrrKeQa3OUAwX/WoG7yqV+
 QUYkoSfxTiSxRaSD0c0f3lSAWXvU3LonOJVilOJ0zxZHFnqRQLndYci6yHcmMEfm
 plsgRmFfsNghwYzl83TUvN4wHYeBiGW6NqQrRorGtjyJrCFAh7w7haOsHJnn2VNd
 6URNEvLuvKezZUwxQVADQS+csDUgJpMUrBK9atPvnL1Ds87WXlM41ZhCJSJSLTxi
 VGVhl4Cl5DrLLj2UbuSjCJnh+dmFdCml66hY1fbOt3GTjmq5CxVGXHWTJb4017K+
 NQWNWjaqw5RPynzBwHRNySEads+21KMaMrY2HbRdEbDHJ7yj9iQaC9q0S2G9jOah
 a/35TxR8y8jR8ne0E2gwhJTqESxpV0uIw15cg9c8gxjVZqMKomx9LJ+DVJZ2mS5M
 9fGsrVv+
 =E0hX
 -----END PGP SIGNATURE-----

parent fef9524
author zhaoxinxin <[email protected]> 1741079005 +0800
committer zhaoxinxin <[email protected]> 1742380969 +0800
gpgsig -----BEGIN PGP SIGNATURE-----

 iQGzBAABCAAdFiEEjX7vigeNSJLimSPEHOcWYk0ZMdEFAmfan6kACgkQHOcWYk0Z
 MdEtrAv/UzvPaH7F5MHDDYy8BYps5KbSDB4mwxmRJLRhcUr/scb072ifI2/5Jm6w
 1zVNWkDVR8OIp+0AfX55XeiUhBNp/08ZCLqwr1bGtIbhJOZUY3o/dXaS/YclfbXo
 zHg37hJpuFyaN1HUv6xrLcnDJMehuU8MINGIBqFu2KdX5TaArM+6OB4pEoHWmn1Z
 761Gb8OT+oP3ndNKwi9gyDTcFAnmcnDFW+U7LtX79vzoRD1yZ5Bz/6NZDGiQvYqE
 w4GHBRNdUOE6L35g3wUS/tfCcrEVcWvREB1YgfS9BEbqIhcNugndxZRdMrkWlXyy
 3JKc4fkPgEVZtgZm8XVX0Oc5LMrI953jzO31ubr7yxcjKzU2UW0xuiDqQ5KHRoQ+
 Zefqk6XgUZB/ZC/aYrq2xxKLobyz+Uklfj771IcxKUA7fWGXl7YHWzAl6kbBJasH
 0okOOonHppbp2LMbRTSfODFiGEfEJ+EIz/ALrOLx9LeuchFs6scsKHberPwFde9c
 pd3tOr0I
 =d3WH
 -----END PGP SIGNATURE-----

fix: Remove top error message about no README or license

Signed-off-by: zhaoxinxin <[email protected]>

Add PKCE support for OIDC authentication (goharbor#21702)

Fixes goharbor#19393

By default Harbor will generate a pkce code and use it in the
authentication flow to interact with OIDC provider.
Per OAuth spec, this should not break the flow for the OIDC provider that does not support PKCE
The code_challenge_method is hard coded to SHA256 for security reason,
and we may consider add more settings in future based on feedbacks.

Signed-off-by: Daniel Jiang <[email protected]>

update tlsOptions for external redis (goharbor#21681)

Signed-off-by: yminer <[email protected]>
Co-authored-by: yminer <[email protected]>

add prepare migration script for 2.13.0 (goharbor#21680)

Signed-off-by: yminer <[email protected]>

Update UI version in package.json to v2.13.0 (goharbor#21606)

update version to 2.13.0

Signed-off-by: bupd <[email protected]>
Co-authored-by: miner <[email protected]>

Change audit log label (goharbor#21703)

Add more description for update user operation change password or set sys admin

Signed-off-by: stonezdj <[email protected]>

feat: implement the CNAI model processor (goharbor#21663)

feat: implement the AI model processor

Signed-off-by: chlins <[email protected]>

fix issue 20828 (goharbor#21726)

* fix issue 20828

fix goharbor#20828

Does not fire event only when the current project is a proxy-cache project and the artifact already exists.

Signed-off-by: wang yan <[email protected]>

consume the downstream distribution (goharbor#21733)

Signed-off-by: wang yan <[email protected]>

Add Missing copyright headers in src/portal (goharbor#21693)

add missing copyright headers to files in UI

Signed-off-by: bupd <[email protected]>
Co-authored-by: Wang Yan <[email protected]>

Add Missing copyright headers in src/portal part 2 (goharbor#21694)

add missing headers part 2

Signed-off-by: bupd <[email protected]>
Co-authored-by: Wang Yan <[email protected]>

Add Missing Headers in UI part 3 (goharbor#21695)

add missing headers in UI part 3

Signed-off-by: bupd <[email protected]>

Replace Vmware to goharbor (goharbor#21696)

replace vmware with goharbor in src/portal

Signed-off-by: bupd <[email protected]>
Co-authored-by: Wang Yan <[email protected]>

Add Lint Check for Copyright Headers in UI (goharbor#21692)

add lint check for headers in UI

Signed-off-by: bupd <[email protected]>

Fix: Copy Pull Button Overlap with Tag Immutable Label (goharbor#21720)

fix: copy button overlap with tag immutable

- fix copy button overlap with tag immutable label on artifact-tag
component
- update css to fix this issue

Signed-off-by: bupd <[email protected]>
Co-authored-by: Wang Yan <[email protected]>

fix i18n issue (goharbor#21748)

Signed-off-by: wang yan <[email protected]>

fix: fix replication of multiple projects with numeric names (goharbor#21474)

Explicitly mark project names as strings

This keeps the server from parsing all-numeric project names as integer
values which it does not like.

Signed-off-by: Chris Girard <[email protected]>
Co-authored-by: Wang Yan <[email protected]>

update golang to v1.23.7 (goharbor#21749)

Signed-off-by: wang yan <[email protected]>

Bump up trivy and trivy-adapter to the latest RC tag (goharbor#21741)

Signed-off-by: Daniel Jiang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s3rj1k s3rj1k s3rj1k left review comments

@stonezdj stonezdj stonezdj approved these changes

@wy65701436 wy65701436 wy65701436 approved these changes

@Vad1mo Vad1mo Vad1mo left review comments

Assignees

@Vad1mo Vad1mo

@wy65701436 wy65701436

@OrlinVasilev OrlinVasilev

Labels
release-note/new-feature New Harbor Feature target/2.13.0 issues that are targeting v2.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implementation for AI model artifact processor
6 participants
@chlins @Vad1mo @stonezdj @wy65701436 @s3rj1k @OrlinVasilev