Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for internal/mkcgo #270

Merged
merged 3 commits into from
Mar 24, 2025
Merged

Add tests for internal/mkcgo #270

merged 3 commits into from
Mar 24, 2025

Conversation

qmuntal
Copy link
Collaborator

@qmuntal qmuntal commented Mar 21, 2025

This PR adds unit tests for the internal/mkcgo package. The coverage is 100% (if that means somethinf 😄):

go test -cover ./internal/mkcgo 
ok      github.com/golang-fips/openssl/v2/internal/mkcgo        7.642s  coverage: 99.6% of statements

I've refactored some APIs to make to make them easier to test, added some additional validations, and fixed some bugs (which shims.h was not exercising) along the way.

Test for cmd/mkcgo will come in a follow-up PR.

@qmuntal qmuntal merged commit cc9339b into v2 Mar 24, 2025
50 checks passed
@qmuntal qmuntal deleted the mkcgounittest branch March 24, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants