This repository was archived by the owner on Sep 9, 2020. It is now read-only.
status: collectConstraints() should collect constraints from root project too #1452
Labels
Comments
|
I'm interested in this one, but I'll probably have some questions for it in the slack. |
|
@JamieCrisman Great! |
|
Will be looking at this more now that #1413 was merged. |
|
Going to need to release for someone else to grab. Sorry for holding it up. |
|
no problem - thanks for communicating about it! |
tinnefeld
added a commit
to tinnefeld/dep
that referenced
this issue
May 20, 2018
The collectConstraints() function in status.go incorporates effective constraints from the root projects manifest. Issue golang#1452.
tinnefeld
added a commit
to tinnefeld/dep
that referenced
this issue
Jun 4, 2018
The collectConstraints() function in status.go incorporates constraints from the root projects manifest. Issue golang#1452.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
collectConstraints()instatus.gocollects constraints declared by all the dependencies. This results in a dependency graph. But since we are not considering the constraints set in the root project, this results in an incomplete graph.Constraints from manifest should be read and included in the returned
constraintsCollection.This can be done with #1409 or separately.
The text was updated successfully, but these errors were encountered: