Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

LoadProject can't handle some relative paths #201

Closed
tro3 opened this issue Jan 31, 2017 · 2 comments
Closed

LoadProject can't handle some relative paths #201

tro3 opened this issue Jan 31, 2017 · 2 comments
Labels

Comments

@tro3
Copy link
Contributor

tro3 commented Jan 31, 2017

For example, for a directory .../src/test that contains manifest.json, LoadProject("./test") will fail if launched from .../src. I'll start a branch/PR to go after this and do a more complete docstring, if indeed this behavior is not desired. If this is outside the use case, feel free to close the issue.

@sdboyer
Copy link
Member

sdboyer commented Jan 31, 2017

I don't think we have any cases where we actually pass a relative path to the function intentionally, but I also don't know if there's any scenarios in which os.Getwd() might return a relative path. So, yes, probably best to cover this. Thanks!

Might this be the cause behind #148?

@sdboyer sdboyer added the bug label Jan 31, 2017
@tro3
Copy link
Contributor Author

tro3 commented Jan 31, 2017

I'll take a look

tro3 pushed a commit to tro3/dep that referenced this issue Jan 31, 2017
sdboyer pushed a commit that referenced this issue Feb 1, 2017
@sdboyer sdboyer closed this as completed Feb 1, 2017
zbintliff added a commit to zbintliff/dep that referenced this issue Mar 3, 2017
krisnova pushed a commit to krisnova/dep that referenced this issue Apr 21, 2017
Relax rules for valid github usernames
ibrasho pushed a commit to ibrasho-forks/dep that referenced this issue May 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants