Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

ensure should never write to the manifest #454

Closed
carolynvs opened this issue Apr 21, 2017 · 2 comments · Fixed by #480
Closed

ensure should never write to the manifest #454

carolynvs opened this issue Apr 21, 2017 · 2 comments · Fixed by #480

Comments

@carolynvs
Copy link
Collaborator

https://github.com/golang/dep/blob/master/cmd/dep/ensure.go#L163 is a bug per #404 (comment). dep ensure should never write to the manifest now that it is user managed.
@carolynvs carolynvs mentioned this issue Apr 21, 2017
Closed
@sdboyer sdboyer mentioned this issue Apr 28, 2017
Merged
@sdboyer
Copy link
Member

sdboyer commented Apr 28, 2017

Turns out this is making some other changes messy. It's going to put commands in a bit of an inconsistent state, but I think we need to go ahead and do this ASAP. (remove should also be changed, even though that command will go away entirely soon).

@carolynvs
Copy link
Collaborator Author

@sdboyer I'll get this submitted today.

@carolynvs carolynvs mentioned this issue Apr 28, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only write to the manifest during dep init carolynvs/dep
2 participants
@sdboyer @carolynvs