This repository was archived by the owner on Sep 9, 2020. It is now read-only.
Only write to the manifest during dep init #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the manifest is user managed, do not rewrite the entire file anymore so as to preserve comments, etc. In the future commands may append/tweak the manifest, but not completely rewrite it.
This is a stop-gap until the new command set is implemented. Remove now only modifies the lock.
|
Excellent, thanks! |
ibrasho
pushed a commit
to ibrasho-forks/dep
that referenced
this pull request
May 10, 2017
Only write to the manifest during dep init
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #454. Now the only command that writes the manifest is
dep init. This does leavedep removeanddep ensure --overridein an inconsistent state until the new command set is implemented.