This repository was archived by the owner on Sep 9, 2020. It is now read-only.
cmd/dep: fix vndr importpath validation #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was relying on a later function erroring out when no import path is present in the config file, instead of explicitly checking for it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
#1013 found a bug in the validation for our vndr importer. It was relying on a later function erroring out when no import path is present in the config file, instead of explicitly checking for it.
What should your reviewer look out for in this PR?
This is small and is blocking another PR, so I'm going to merge myself once the tests pass.
Do you need help or clarification on anything?
Nope.
Which issue(s) does this PR fix?
Unblocks #1013