This repository was archived by the owner on Sep 9, 2020. It is now read-only.
status: use unpaired ver constr when checking updateability #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes fixes a bug due to which the LATEST field in status was missing for projects that were not in manifest but in lock and had pairedVersion. Since we check `bs.Version` to not be nil before entering into updateability block, we can use the same value as the constraint for matching with the version list obtained for the projects.
|
cool, it looks like the problem was something like what we were guessing earlier today on the call. this fix seems fine. i do think it's important that we encode our expectations around "LATEST" into a test - but this is a fix to a regression, so i'm not going to block it on that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
This changes fixes a bug due to which the LATEST field in status was
missing for projects that were not in manifest but in lock and had
pairedVersion.
Since we check
bs.Versionto not be nil before entering intoupdateability block, we can use the same value as the constraint for
matching with the version list obtained for the projects.
What should your reviewer look out for in this PR?
Impact of this change in other part of the code.
Do you need help or clarification on anything?
Which issue(s) does this PR fix?
Fixes #1462