-
Notifications
You must be signed in to change notification settings - Fork 1k
Cleanup init verbose output #604
Cleanup init verbose output #604
Conversation
8233f79
to
7925d3f
Compare
With this, as discussed in #512, dep init feedback would contain the hints/inputs of the init mode. When a local search is performed (GOPATH), the data obtained from the search is logged as feedback. Dependencies that require network to resolve are enumerated separately. No constraint details are logged. Only the direct dependencies are enumerated, no transitive dependencies.
|
cmd/dep/init.go
Outdated
// be added to manifest. | ||
if _, ok := pd.notondisk[pr]; ok { | ||
// If it's in notondisk, add to manifest, these are direct dependencies. | ||
if contains(notondisk, string(pr)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change this from a constant time map lookup into a O(N)
slice scan?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops! right 😅
Thanks
7925d3f
to
e6fb86d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one super-small nit! 😄
if _, ok := pd.notondisk[pr]; ok { | ||
m.Dependencies[pr] = getProjectPropertiesFromVersion(x.Version()) | ||
feedback(x.Version(), pr, fb.DepTypeDirect, ctx) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we don't log feedback for new projects found by the solver, let's update the comment on the for loop to remove log feedback for all the new projects
on line 184.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow! thanks for noticing that 😊
- Remove "dep:" prefix logs. - Remove logging gps solution lock constraints, instead enumerate not on disk projects.
e6fb86d
to
2ae37d6
Compare
projects.