This repository was archived by the owner on Sep 9, 2020. It is now read-only.
[WIP] [#302] Solution now exposes messages and warnings. #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have enhanced rootdata.getApplicableContraints() to now also return unused (ineffectual) constraints. Remaining issue is that one test still fails, and I am unsure why.
|
Ack, I'm sorry it took me so long to respond on this - you went ahead with the approach of expanding |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for issue #302, attempting to report ineffectual constraints. Considering solver.Solve() and Solution struct have no way of reporting messages/warnings, I have decided to add generic Solution.Messages() []string method that can return generic string messages.
The fix is using rootdata.getApplicableConstraints(), where I have modified it to return both applicable and ineffectual (not applicable) ones.
I need a bit of help/hint with the one of the test cases. In the test TestBasicSolves/override_dep's_constraint I do not understand why is "b 2.0.0" reported as ineffectual, because it is also part of the solution.
I would also like your opinions if you are OK with this way of reporting warnings, or would you like a more elaborate, i.e. struct based rather then string warnings, that can return actionable meta data.