This repository was archived by the owner on Sep 9, 2020. It is now read-only.
dep: remove usage of filepath.FromSlash & filepath.ToSlash in context.go #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrasho
changed the title
Remove the usage of filepath.FromSlash and filepath.ToSlash in GOPATH detection functions *Ctx.SetPaths and *Ctx.detectGOPATH. This should ensure the GOPATH returned from *Ctx.DetectProjectGOPATH uses the filesystem separator instead of slashes. Signed-off-by: Ibrahim AshShohail <[email protected]>
ibrasho
force-pushed
the
remove-slashing-in-SetPaths-DetectProjectGOPATH
branch
from
b09dbed to
6e2930f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the usage of
filepath.FromSlashandfilepath.ToSlashinGOPATHdetection functions
*Ctx.SetPathsand*Ctx.detectGOPATH.This should ensure the
GOPATHreturned from*Ctx.DetectProjectGOPATHuses the filesystem separator instead of slashes.
What does this do / why do we need it?
*Ctx.SetPathsconverts GOPATHs to use slashes. This is unnecessary and could cause issues on filesystems that don't use slashes as a separator.