Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: TestStackBarrierProfiling failing on ppc64, ppc64le and mips64 #13334

Closed
minux opened this issue Nov 19, 2015 · 3 comments
Closed

runtime: TestStackBarrierProfiling failing on ppc64, ppc64le and mips64 #13334

minux opened this issue Nov 19, 2015 · 3 comments
Milestone

Comments

@minux
Copy link
Member

minux commented Nov 19, 2015

On linux/mips64:
panic: fatal error: mallocgc called with gcphase == _GCmarktermination
http://build.golang.org/log/2f49c7ce157ca522bfd747254573ce47c7a6564c

On linux/ppc64 and linux/ppc64le:

--- FAIL: TestStackBarrierProfiling (0.61s)
    pprof_test.go:338: subprocess failed with signal: segmentation fault:
FAIL

http://build.golang.org/log/af07ab5aa4c14e100952d98de41012f28a302b00
http://build.golang.org/log/d8c0744f5e27b972a383bb3dae01834cb2d601ce

/cc: @aclements

@minux minux added this to the Go1.6 milestone Nov 19, 2015
@aclements
Copy link
Member

I'm working on getting access to a ppc64 box I can debug this on (the one I had access to went away).

My completely unsubstantiated guess is that GODEBUG=gcstackbarrierall=1 just doesn't work on ppc64. It chews up a lot of stack space and it may just chew up too much on ppc64.

@aclements aclements self-assigned this Nov 20, 2015
@aclements
Copy link
Member

It looks like my guess was right, so I'll probably just disable this test on ppc64 (it's not worth making gcstackbarrierall work on ppc64).

The mips64 failure looks like the test is catching a genuine bug.

mk0x9 pushed a commit to mk0x9/go that referenced this issue Nov 20, 2015
This test depends on GODEBUG=gcstackbarrierall, which doesn't work on
ppc64.

Updates golang#13334.

Change-Id: Ie554117b783c4e999387f97dd660484488499d85
Reviewed-on: https://go-review.googlesource.com/17120
Run-TryBot: Austin Clements <[email protected]>
Reviewed-by: Russ Cox <[email protected]>
@aclements
Copy link
Member

624d798 fixed the ppc64 bug and the mips64 bug is a dup of #12528.

@golang golang locked and limited conversation to collaborators Nov 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants