Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/exp/apidiff: support for go/types.Alias #70695

Closed
timothy-king opened this issue Dec 5, 2024 · 5 comments
Closed

x/exp/apidiff: support for go/types.Alias #70695

timothy-king opened this issue Dec 5, 2024 · 5 comments
Assignees
@jba
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.24

Comments

@timothy-king
Copy link
Contributor

golang.org/x/exp/apidiff should be updated to support go/types producing Alias nodes. This is required for these tools to type check input code containing type parameterized alias nodes (1.24).

Additionally golang.org/x/exp/cmd/{apidiff, gorelease} should have the gotypesalias=1 GODEBUG setting enabled by default when built with a toolchain >= 1.24. See https://go.dev/cl/627715 for an example of how to do this.

See #69772 for additional context.
@timothy-king timothy-king added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 5, 2024
@timothy-king timothy-king added this to the Go1.24 milestone Dec 5, 2024
@gabyhelp
Copy link

gabyhelp commented Dec 5, 2024

Related Issues

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

This was referenced Dec 5, 2024
Open
Open
@adonovan
Copy link
Member

adonovan commented Dec 5, 2024

@jba

@jba jba self-assigned this Dec 5, 2024
@seankhliao seankhliao changed the title golang.org/x/exp/apidiff: support for go/types.Alias x/exp/apidiff: support for go/types.Alias Dec 28, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/644877 mentions this issue: apidiff: support types.Alias

gopherbot pushed a commit to golang/exp that referenced this issue Jan 28, 2025
@jba
apidiff: support types.Alias
3edf0e9 
Use types.Unalias as needed.

For golang/go#70695.

Change-Id: I8595783d9a4c0eef332801135bde490cf745a206
Reviewed-on: https://go-review.googlesource.com/c/exp/+/644877
Reviewed-by: Alan Donovan <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/645015 mentions this issue: cmd/{apidiff,gorelease}: use types.Alias when >= 1.23

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/650135 mentions this issue: cmd/{apidiff,gorelease}: delete redundant //go:debug gotypesalias=1 directives [generated]

gopherbot pushed a commit to golang/exp that referenced this issue Feb 18, 2025
@dmitshur @gopherbot
cmd/{apidiff,gorelease}: delete redundant //go:debug gotypesalias=1 d…
aa4b98e 
…irectives [generated]

The module's go directive is >= 1.23 now,
so these files no longer have any effect.

For golang/go#70695.
For golang/go#69772.

[git-generate]
find . -type f -name gotypesalias.go -exec rm {} +

Change-Id: Ia9f62875bc73a43f30eda7de873db5d342d8b991
Reviewed-on: https://go-review.googlesource.com/c/exp/+/650135
Auto-Submit: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jba jba

Labels
NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.24
Development

No branches or pull requests
5 participants
@timothy-king @adonovan @gopherbot @jba @gabyhelp