Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Setting GOROOT" custom install instruction #25130

Closed
wants to merge 1 commit into from
Closed

Remove "Setting GOROOT" custom install instruction #25130

wants to merge 1 commit into from

Conversation

JoeCortopassi
Copy link
Contributor

@JoeCortopassi JoeCortopassi commented Apr 27, 2018

doc: Setting GOROOT is no longer necessary for custom installation as of 1.10 (https://go-review.googlesource.com/c/go/+/42533)

Fixes #25002

This PR will be imported into Gerrit with the title and first
comment (this text) used to generate the subject and body of
the Gerrit change.

Please ensure you adhere to every item in this list.

More info can be found at https://github.com/golang/go/wiki/CommitMessage

  • The PR title is formatted as follows: net/http: frob the quux before blarfing
    • The package name goes before the colon
    • The part after the colon uses the verb tense + phrase that completes the blank in,
      "This change modifies Go to ___________"
    • Lowercase verb after the colon
    • No trailing period
    • Keep the title as short as possible. ideally under 76 characters or shorter
  • No Markdown
  • The first PR comment (this one) is wrapped at 76 characters, unless it's
    really needed (ASCII art, table, or long link)
  • If there is a corresponding issue, add either Fixes #1234 or Updates #1234
    (the latter if this is not a complete fix) to this comment
  • If referring to a repo other than golang/go you can use the
    owner/repo#issue_number syntax: Fixes golang/tools#1234
  • We do not use Signed-off-by lines in Go. Please don't add them.
    Our Gerrit server & GitHub bots enforce CLA compliance instead.
  • Delete these instructions once you have read and applied them

Setting GOROOT is no longer necessary for custom installation as of 1.10 (https://go-review.googlesource.com/c/go/+/42533)

Link to reporting issue here: #25002
@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Apr 27, 2018
@gopherbot
Copy link
Contributor

This PR (HEAD: 156bf65) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/109955 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gerrit Bot:

Uploaded patch set 2: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/109955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit Bot:

Uploaded patch set 3: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/109955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Giovanni Bajo:

Patch Set 3:

Please, read https://tip.golang.org/doc/contribute.html#commit_messages on how to write commit messages. You will have to edit the GitHub PR description to change it (have a look at how it appears in Gerrit).


Please don’t reply on this GitHub thread. Visit golang.org/cl/109955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 3:

https://github.com/golang/go/wiki/CommitMessage also has good docs on this.


Please don’t reply on this GitHub thread. Visit golang.org/cl/109955.
After addressing review feedback, remember to publish your drafts!

@agnivade
Copy link
Contributor

agnivade commented May 1, 2018

You should abandon golang.org/cl/109955.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: setting GOROOT is not necessary when installing to custom location
4 participants