Fix missing RVV gemm kernel descriptions and regenerate tests/benchmarks #7888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_731115584
branch
from
37133e2 to
688b07a
Compare
ken-unger
reviewed
Mar 10, 2025
bench/qs8-qc8w-gemm-fp32.cc
Outdated
| xnn_qs8_qc8w_gemm_minmax_fp32_ukernel_1x4v__rvv, | ||
| xnn_init_qs8_qc8w_conv_minmax_fp32_scalar_params, | ||
| xnn_pack_qs8_gemm_goi_w, | ||
| /*mr=*/1, /*nr=*/4 * xnn_init_hardware_config()->vlenb / sizeof(int8_t), /*kr=*/1, /*sr=*/1, |
There was a problem hiding this comment.
@dsharlet I looked into this while fixing PR #7932. Sizeof() here needs to be int32_t for qc8w.
Changing https://github.com/google/XNNPACK/blob/master/tools/generate-gemm-test.py#L741 to be "qs8": "int32_t", resolves the problem, and the tests pass successfully. I'm not sure if this line should be further qualified by the 'activation' although there is currently no qs8-gemm rvv implementation, and so perhaps that single change is sufficient.
copybara-service
bot
force-pushed
the
test_731115584
branch
2 times, most recently
from
2179a5c to
e90b94f
Compare
PiperOrigin-RevId: 735236954
copybara-service
bot
force-pushed
the
test_731115584
branch
from
e90b94f to
f481f28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing RVV gemm kernel descriptions and regenerate tests/benchmarks