Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a separate field for expressions under input bindings map #449

Merged
merged 22 commits into from
Mar 19, 2025
Merged

Add a separate field for expressions under input bindings map #449

merged 22 commits into from
Mar 19, 2025
+464 −199

Conversation

aakash070
Copy link
Contributor

This change breaks up the Bindings map value into 2 parts:

  1. An expr.Value which contains simple literal values
  2. A string expression which contains a CEL expression that evaluates to the value of the variable binding. The expression will be evaluated using the same CEL runtime environment as the one being used to trigger the test.

aakash070 and others added 21 commits February 18, 2025 10:15
@aakash070
Add test_suite and test_config under conformance
e603acf
@aakash070
added test_config.pb.go and test_suite.pb.go to conforanmce library b…
11f0c54 
…uild target
@aakash070
added test suite messages to simple.proto and updated test_config to …
547fc51 
…env_config
@aakash070
add uncommitted files
f41fcf0
@aakash070
updated build files for generated conformance and test code
c828e49
@aakash070
corrected field name in env_config
021315f
@aakash070
replaced Variable and Function messages with cel.expr.DEcl
c788f43
@aakash070
resolved comments
c409cde
@aakash070
removed redundant any from simple proto
6938c59
@aakash070
added context_message as an input kind to test case
3c97ae0
@aakash070
removed redundant anypb import in env_config
094030b
@aakash070
update type_name to context_variable_type to conform with linting rules
19a04f2
@aakash070
moved test suite, test section and test case to suite.proto under con…
49c3aea 
…formance/test
@aakash070
update context variable attribute name to type_name
98e0c5e
@aakash070
Merge branch 'google:master' into master
40dec58
@aakash070
removed redundant FileDescriptor field from config
3757b44
@aakash070
Revert "removed redundant FileDescriptor field from config"
b6fd6c9 
This reverts commit 3757b44.
@aakash070
Merge branch 'google:master' into master
0bef4ae
@aakash070
added separate identifier field for expression type inputs to test case
18fd60c
@aakash070
corrected comment on input value expr
c7efb27
@aakash070
corrected comment on input value expr
f3b7612
@TristonianJones
Copy link
Collaborator

/gcbrun

@TristonianJones
Copy link
Collaborator

@l46kok would you be able to review this change. We discussed something similar yesterday.

@l46kok
Copy link
Collaborator

l46kok commented Mar 19, 2025

/gcbrun

@l46kok l46kok merged commit ae6fb0d into google:master Mar 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l46kok l46kok l46kok approved these changes

Assignees

@l46kok l46kok

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aakash070 @TristonianJones @l46kok