Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mdbook to 0.4.28 #480

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Update mdbook to 0.4.28 #480

merged 2 commits into from
Mar 7, 2023

Conversation

mgeisler
Copy link
Collaborator

@mgeisler mgeisler commented Mar 6, 2023

This version contains rust-lang/mdBook#1986 which will allow us to test the code in each translation.

This version contains rust-lang/mdBook#1986 which will allow us to test the code in each translation.
@jooyunghan
Copy link
Collaborator

Just curious, why did you need to update ko.po?

However, the formatting for the changed text in English looks like:
image

And in Korean:
image

I think the original text should have used ``` instead of `.

The Korean translation seems wrong ;-) I'll fix it in a next round.

The extra code block made `mdbook test` fail.
@mgeisler
Copy link
Collaborator Author

mgeisler commented Mar 7, 2023

I think the original text should have used ``` instead of `.

Yes, I completely agree: the formatting in English is weird and should be fixed there. I'm sorry I didn't spot that in #169 (@qwandor).

The golden rule of working with i18n is that you cannot "fix" anything in the translations, apart from typos in the source text. You have to follow the original in terms of formatting, otherwise the two versions will start to drift apart and that makes your life very hard when it comes to tracking changes.

@mgeisler mgeisler merged commit e366d83 into main Mar 7, 2023
@mgeisler mgeisler deleted the mgeisler-patch-1 branch March 7, 2023 09:14
@mgeisler mgeisler mentioned this pull request Mar 7, 2023
NoahDragon pushed a commit to wnghl/comprehensive-rust that referenced this pull request Jul 19, 2023
* Update mdbook to 0.4.28

This version contains rust-lang/mdBook#1986 which will allow us to test the code in each translation.

* Fix formatting in Korean translation

The extra code block made `mdbook test` fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants