Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary MembersInjectors.injectMembers method #950

Closed
wants to merge 3 commits into from
Closed

Remove unnecessary MembersInjectors.injectMembers method #950

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b98f194
Remove injectMembers method from MembersInjectors
szymonkozak Nov 14, 2017
6f810c7
Change checkInstanceNotNull to private static in MembersInjectors
szymonkozak Nov 14, 2017
036f378
Inline checkNottNull in MembersInjectors class
szymonkozak Nov 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions java/dagger/internal/MembersInjectors.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,6 @@
* @since 2.0
*/
public final class MembersInjectors {
/**
* Injects members into {@code instance} using {@code membersInjector}. This method is a
* convenience for cases in which you would want to chain members injection, but can't because
* {@link MembersInjector#injectMembers} returns {@code void}.
*/
public static <T> T injectMembers(MembersInjector<T> membersInjector, T instance) {
membersInjector.injectMembers(instance);
return instance;
}

/**
* Returns a {@link MembersInjector} implementation that injects no members
Expand All @@ -53,13 +44,9 @@ private static enum NoOpMembersInjector implements MembersInjector<Object> {
INSTANCE;

@Override public void injectMembers(Object instance) {
checkInstanceNotNull(instance);
checkNotNull(instance, "Cannot inject members into a null reference");
}
}

public static void checkInstanceNotNull(Object instance) {
checkNotNull(instance, "Cannot inject members into a null reference");
}

private MembersInjectors() {}
}