Update/modernize the Bazel build tooling. #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes: - Adding a .bazelignore so building `...` doesn't try to build the node_modules directory. - Removing a bazelrc flag that no longer exists and isn't needed anymore. - Switching to a modern rollup_bundle implementation. This requires: - Adding a config file to set the global name and license banner. - Generating output formats separately, since it no longer generates all of them. - Using the Rollup Buble plugin to downlevel (transpile) to ES5. - Switching npm_package to the modern pkg_npm. - This cleans up some "replacements" (formerly called "substitutions") - Switching from `bazel` to `bazelisk` as `bazel` is now [deprecated](https://www.npmjs.com/package/@bazel/bazel) for this use case. - Upgrading to rules_nodejs version 4.6.0. - Switching `ts_web_test` to the modern `karma_web_test` (which is in the `@bazel/concatjs` package). The JS output is roughly the same. There are some small changes related to variable renaming and optimizations that shouldn't affect runtime behavior. The main difference is that the const `DEBUG` replacements now work (before the `DEBUG` const got inlined before the replacement step).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes:
...doesn't try to build the node_modules directory.bazeltobazeliskasbazelis now deprecated for this use case.ts_web_testto the modernkarma_web_test(which is in the@bazel/concatjspackage).The JS output is roughly the same. There are some small changes related to variable renaming and optimizations that shouldn't affect runtime behavior. The main difference is that the const
DEBUGreplacements now work (before theDEBUGconst got inlined before the replacement step).