-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --locked
to installation of cargo fuzz
#12178
Add --locked
to installation of cargo fuzz
#12178
Conversation
Helps pin dependencies at the time of when `cargo-fuzz` itself was published to avoid dependency updates breaking builds. This fixes a current issue where all Rust projects using `cargo fuzz` are broken due to the installation of `cargo-fuzz` failing due to failing to build a newer dependency with an older nightly. Closes google#12168
/gcbrun trial_build.py rust |
Hope it solves https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=70200 libhtp fuzzing build failure, thanks Alex |
According to the logs it looks like a timeout with gitoxide caused the run to fail. I'm not sure if that's hiding other failures, but locally I've built gitoxide with this and it succeeds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a ton for this!
@alexcrichton I still get
for libhtp running Do you know how to fix it ? |
@catenacyber that look like libhttp will want to downgrade the serde it's using. It's the same root cause as this issue but in a different place. For example The only other option is to update rustc but that seems like it's blocked on quite a few other things, so it likely won't happen soon. |
Thanks, trying something in #12217 |
Helps pin dependencies at the time of when
cargo-fuzz
itself was published to avoid dependency updates breaking builds. This fixes a current issue where all Rust projects usingcargo fuzz
are broken due to the installation ofcargo-fuzz
failing due to failing to build a newer dependency with an older nightly.Closes #12168