This repository was archived by the owner on Oct 14, 2021. It is now read-only.
Fold starlark_module! macro a bit more #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clippy: rust-lang/rust-clippy#4133 |
damienmg
approved these changes
May 27, 2019
Introduce the intermediate step which does a transformation like: ``` x: String, ... ``` into ``` (named) x: String, ... ``` so both named and unnamed arguments are handled uniformly by matching on `$is_named:tt $t:ident` (`# x` or `(named) x`). Resulting macros are even more complicated than before but contain fewer repetitions (and fewer LOC), so it's possible to extend them further without drowning in copypasta.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the intermediate step which does a transformation like:
into
so both named and unnamed arguments are handled uniformly by matching
on
$is_named:tt $t:ident(# xor(named) x).Resulting macros are even more complicated than before but contain
fewer repetitions (and fewer LOC), so it's possible to extend them
further without drowning in copypasta.