ci: Airlock-friendly plugin dependency declarations #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Maven plugins are not needed during releases. Let's use profiles to avoid requiring the plugins unnecessarily.
meltsufin
reviewed
Mar 13, 2025
| @@ -128,4 +115,29 @@ | |||
| <scope>test</scope> | |||
| </dependency> | |||
| </dependencies> | |||
| <profiles> | |||
| <profile> | |||
| <id>animal-sniffer</id> | |||
There was a problem hiding this comment.
Isn't this already declared in the parent pom?
| @@ -589,6 +598,69 @@ | |||
| </build> | |||
| </profile> | |||
|
|
|||
| <profile> | |||
| <id>clirr-compatibility-check</id> | |||
There was a problem hiding this comment.
Would it make sense to combine clirr-compatibility-check and animal-sniffer under one profile like compatibility-checks?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Maven plugins are not needed during releases. Let's use
profiles to avoid requiring the plugins unnecessarily.