Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mark CLIRR check optional #2434

Merged
merged 6 commits into from
May 15, 2023
Merged

chore: mark CLIRR check optional #2434

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
63b0569
chore: mark CLIRR check optional
rajatbhatta May 15, 2023
a5a1e64
Update pre-commit hook
rajatbhatta May 15, 2023
162a498
Update snapshot.sh
rajatbhatta May 15, 2023
f85e62a
Update samples.yaml
rajatbhatta May 15, 2023
046d990
Update pre-commit
rajatbhatta May 15, 2023
2ea318c
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/sync-repo-settings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ branchProtectionRules:
- dependencies (8)
- dependencies (11)
- lint
- clirr
- units (8)
- units (11)
- 'Kokoro - Test: Integration'
Expand Down Expand Up @@ -74,7 +73,6 @@ branchProtectionRules:
requiresStrictStatusChecks: false
requiredStatusCheckContexts:
- lint
- clirr
- units (8)
- units (11)
- 'Kokoro - Test: Integration'
Expand All @@ -87,7 +85,6 @@ branchProtectionRules:
requiresStrictStatusChecks: false
requiredStatusCheckContexts:
- lint
- clirr
- units (8)
- units (11)
- 'Kokoro - Test: Integration'
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/samples.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
java-version: 11
distribution: zulu
- name: Compile Spanner
run: mvn clean install
run: mvn clean install -Dclirr.skip=true
- uses: actions/setup-java@v3
with:
java-version: 8
Expand All @@ -44,7 +44,7 @@ jobs:
java-version: ${{matrix.java}}
distribution: zulu
- name: Compile Spanner
run: mvn clean install
run: mvn clean install -Dclirr.skip=true
- name: Compile samples
run: mvn compile
working-directory: samples
working-directory: samples
3 changes: 2 additions & 1 deletion .kokoro/release/snapshot.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,5 @@ mvn clean deploy -B \
-DperformRelease=true \
-Dgpg.executable=gpg \
-Dgpg.passphrase=${GPG_PASSPHRASE} \
-Dgpg.homedir=${GPG_HOMEDIR}
-Dgpg.homedir=${GPG_HOMEDIR} \
-Dclirr.skip=true
8 changes: 0 additions & 8 deletions git-hooks/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,3 @@
#!/bin/sh
#
# Copy this file into your .git/hooks folder

set -e

# Checks for:
# - Formatting errors
# - Clirr errors
mvn com.coveo:fmt-maven-plugin:check clirr:check